Game sometimes crashes when items leave inventory #2

New issue

Open

opened 2025-02-21 21:41:47 +00:00 by emakman · 4 comments

emakman commented

2025-02-21 21:41:47 +00:00

Owner

No description provided.

image.png

9.2 MiB

image.png

1.4 MiB

emakman added the

bug

label

2025-02-21 21:41:47 +00:00

emakman changed title from ~~Game crashes when bringing package to treek~~ to Game crashes when bringing package to treek and when turning in baubles

2025-02-21 21:48:47 +00:00

emakman changed title from ~~Game crashes when bringing package to treek and when turning in baubles~~ to Game sometimes crashes when items leave inventory

2025-02-21 22:48:53 +00:00

emakman commented

2025-02-21 22:50:45 +00:00

Author

Owner

I'm going to look into the code that removes remote items from the inventory to see if that's responsible.

having seen some more examples of this, I think the likely common denominator is an item leaving the inventory, and my guess it is specifically an item leaving the inventory when the last item picked up was a remote item. I'm going to look into the code that removes remote items from the inventory to see if that's responsible.

emakman commented

2025-04-06 18:56:07 +00:00

Author

Owner

Changed the item removal code in 0a01e4bf55.

Changed the item removal code in 0a01e4bf55.

emakman commented

2025-05-27 16:33:04 +00:00

Author

Owner

Attached are a save file which can reproduce the crash and the corresponding minidump file (from the epic version).

The crash can be reproduced by traveling left from the save point, putting mail in the mailbox, and then giving the toolbox to Sandro.

Attached are a save file which can reproduce the crash and the corresponding minidump file (from the epic version). The crash can be reproduced by traveling left from the save point, putting mail in the mailbox, and then giving the toolbox to Sandro.

bug_give_item.zip

50 KiB

bug_give_item.dmp

170 KiB

emakman commented

2025-05-27 16:36:22 +00:00

Author

Owner

Having looked a 3 different minidump files from different instances of the bug, it appears to consistently happen at address 0x140297c03 in the epic version of the game. That's an access to a field on the last item in the inventory; so it seems the fix should simply require making the last-item pointer on the inventory point to an item that still exists. (I'm not clear on why that isn't already the case; the change from 0a01e4bf55 was supposed to handle that).

Having looked a 3 different minidump files from different instances of the bug, it appears to consistently happen at address `0x140297c03` in the epic version of the game. That's an access to a field on the last item in the inventory; so it seems the fix should simply require making the last-item pointer on the inventory point to an item that still exists. (I'm not clear on why that isn't already the case; the change from 0a01e4bf55 was supposed to handle that).