filler-items #3

Closed

marcmagus wants to merge 3 commits from marcmagus/YokuAPWorld:filler-items into main

marcmagus commented

2025-03-07 17:12:53 +00:00

Contributor

Adds an override for get_filler_item_name (the documented way to provide extra fillers) and a list of acceptable items to populate it.

From apworld_dev_faq and AutoWorld.py this appears to be the correct way to provide a fallback.

per Tamva the game handles >80 Wickerlings acceptably, so they should be ok in the filler pool until such time as they are progression

Adds an override for `get_filler_item_name` (the documented way to provide extra fillers) and a list of acceptable items to populate it. From [apworld_dev_faq](https://github.com/ArchipelagoMW/Archipelago/blob/main/docs/apworld_dev_faq.md#i-have-multiple-settings-that-change-the-itemlocation-pool-counts-and-need-to-balance-them-out) and `AutoWorld.py` this appears to be the correct way to provide a fallback. per Tamva the game handles >80 Wickerlings acceptably, so they should be ok in the filler pool until such time as they are progression

marcmagus added 3 commits

2025-03-07 17:12:54 +00:00

Add missing get_filler_item_name and specified list of filler items, move Dirty Sootlings to type JUNK e04984b624

typo 64d155e0af

Revert item cleanup for clean PR, will add those to a future PR aceded86c5

emakman commented

2025-03-08 01:57:54 +00:00

Owner

this seems mostly good, but I want to keep all the data I can in the item table, so I'd rather the filler item list be made by list comprehension

emakman commented

2025-03-12 04:22:54 +00:00

Owner

You mentioned on discord that it might be helpful to split ItemType.JUNK into two categories. PR #5 changes the item table significantly, including splitting ItemType.JUNK into ItemType.JUNK and ItemType.FILLER. If we merge those changes, then the list comprehension bit should be easy.

You mentioned on discord that it might be helpful to split `ItemType.JUNK` into two categories. PR #5 changes the item table significantly, including splitting `ItemType.JUNK` into `ItemType.JUNK` and `ItemType.FILLER`. If we merge those changes, then the list comprehension bit should be easy.

👍 1