Archipelago/YokuAPWorld
1
0
Fork 1
Code Issues Pull requests Projects Releases 4 Packages Wiki Activity Actions

item-classification #4

Closed
marcmagus wants to merge 2 commits from marcmagus/YokuAPWorld:item-classification into main
pull from: marcmagus/YokuAPWorld:item-classification
merge into: Archipelago:main
Conversation 4 Commits 2 Files changed 2 +45 -5
marcmagus commented 2025-03-07 22:16:02 +00:00
Contributor
Copy link

Conditionally changes the classification of certain items during create_item

I observed in async play that helpful players are noticing when they find a progression item of mine and alerting me, and with 6 trackers and 6 Dirty Sootlings in that category it's a lot. This reclassifies items more correctly:

Dirty Sootlings are always JUNK (they are a quest but it is never required by logic)
Tadpoles moved to group QUEST for consistency

Conditionally:
Normal: Grand Postmaster Badge adjusted to useful
Hard: Grand Postmaster Badge adjusted to useful, Trackers adjusted to junk
Very Hard: Trackers, Mushrooms, and Postal Badge adjusted to junk

Conditionally changes the `classification` of certain items during `create_item` I observed in async play that helpful players are noticing when they find a `progression` item of mine and alerting me, and with 6 trackers and 6 Dirty Sootlings in that category it's a lot. This reclassifies items more correctly: Dirty Sootlings are always `JUNK` (they are a quest but it is never required by logic) Tadpoles moved to group `QUEST` for consistency Conditionally: Normal: Grand Postmaster Badge adjusted to `useful` Hard: Grand Postmaster Badge adjusted to `useful`, Trackers adjusted to `junk` Very Hard: Trackers, Mushrooms, and Postal Badge adjusted to `junk`
emakman commented 2025-03-08 01:44:25 +00:00
Owner
Copy link

These changes don't pass tests atm because the sootlings are in logic for the in-game randomizer, and I haven't removed them from the logic we're using yet. I've adjusted my generator scripts to produce the correct logic, but since I'm working from different input for the new generator, I hadn't quite finished those updates yet.

These changes don't pass tests atm because the sootlings are in logic for the in-game randomizer, and I haven't removed them from the logic we're using yet. I've adjusted my generator scripts to produce the correct logic, but since I'm working from different input for the new generator, I hadn't quite finished those updates yet.
emakman commented 2025-03-08 07:45:15 +00:00
Owner
Copy link

OK, so after you messaged me, I double-checked the logic and you're right that this change is fine. (I was mixing up needed changes; It's the Skvader which is not progressive but is marked progressive because of some faulty logic.)

OK, so after you messaged me, I double-checked the logic and you're right that this change is fine. (I was mixing up needed changes; It's the Skvader which is not progressive but is marked progressive because of some faulty logic.)
marcmagus commented 2025-03-08 12:45:14 +00:00
Author
Contributor
Copy link

Agreed re: Skvader, it would be nice to move that to useful but it requires either a bugfix or blacklisting Skvader from certain locations first.

I got Grand Postmaster Badge wrong, my apologies. It needs to be progression in all modes.

Agreed re: Skvader, it would be nice to move that to useful but it requires either a bugfix or blacklisting Skvader from certain locations first. I got Grand Postmaster Badge wrong, my apologies. It needs to be `progression` in all modes.
emakman commented 2025-07-14 03:10:45 +00:00
Owner
Copy link

Closed by 07e5cbe1b2

Closed by 07e5cbe1b2
emakman closed this pull request 2025-07-14 03:10:46 +00:00

Pull request closed

Please reopen this pull request to perform a merge.
Sign in to join this conversation.
Reviewers
No reviewers
Labels
Clear labels
No items
No labels
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
2 participants
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference: Archipelago/YokuAPWorld#4
No description provided.
Delete branch "marcmagus/YokuAPWorld:item-classification"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?